Add selection to TextInput onChange event#55000
Open
alanleedev wants to merge 1 commit intofacebook:mainfrom
Open
Add selection to TextInput onChange event#55000alanleedev wants to merge 1 commit intofacebook:mainfrom
alanleedev wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: This change adds `selection` data to the `TextInput.onChange` event for both iOS and Android platforms. ## Why On the web, text input elements provide `selectionStart` and `selectionEnd` properties that are always accessible during input events. This is a W3C DOM standard that enables common use cases like: - mention and tagging systems (insert at cursor position) - Autocomplete/typeahead (replace text at cursor) - Input masking (format text while maintaining cursor position) - Rich text editing features React Native's `onChange` event previously included `selection` on iOS (Fabric), but this was removed in D76253999 to unify with Android (which never had it). This change restores and extends this capability to both platforms, better aligning React Native with web standards. ## What Changed 1. **Flow Types**: Added optional `selection?: Selection` to `TextInputChangeEventData` 2. **iOS/macOS (C++)**: Enable selection in `onChange` event via `TextInputEventEmitter` 3. **Android (Kotlin)**: Added selection data to `ReactTextChangedEvent` 4. **RNTester**: Updated examples to verify the change ## Changelog [General][Added] - TextInput onChange event now includes selection data on iOS and Android Differential Revision: D89898092
meta-cla
bot
added
the
CLA Signed
|
@alanleedev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89898092. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds
selectiondata to theTextInput.onChangeevent for both iOS and Android platforms.Why
On the web, text input elements provide
selectionStartandselectionEndproperties that are always accessible during input events. This is a W3C DOM standard that enables common use cases like:React Native's
onChangeevent previously includedselectionon iOS (Fabric), but this was removed in D76253999 to unify with Android (which never had it). This change restores and extends this capability to both platforms, better aligning React Native with web standards.What Changed
selection?: SelectiontoTextInputChangeEventDataonChangeevent viaTextInputEventEmitterReactTextChangedEventChangelog
[General][Added] - TextInput onChange event now includes selection data on iOS and Android
Differential Revision: D89898092